Skip to content

fix: infinite dataloader reset on every baseParams change #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

fix: infinite dataloader reset on every baseParams change #2598

merged 2 commits into from
Jun 16, 2025

Conversation

DorianMaliszewski
Copy link
Member

No description provided.

@DorianMaliszewski DorianMaliszewski self-assigned this May 15, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a869555

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-dataloader Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (dbefa8e) to head (a869555).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/use-dataloader/src/useInfiniteDataLoader.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   81.13%   81.09%   -0.04%     
==========================================
  Files          30       30              
  Lines        1060     1058       -2     
  Branches      139      140       +1     
==========================================
- Hits          860      858       -2     
  Misses        180      180              
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DorianMaliszewski DorianMaliszewski enabled auto-merge (squash) June 16, 2025 09:16
@DorianMaliszewski DorianMaliszewski merged commit 70852bc into main Jun 16, 2025
5 checks passed
@DorianMaliszewski DorianMaliszewski deleted the fix/infinite-dl-effects branch June 16, 2025 09:17
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philibea philibea philibea approved these changes

@Lawndlwd Lawndlwd Lawndlwd approved these changes

@johnrazeur johnrazeur Awaiting requested review from johnrazeur

Assignees

@DorianMaliszewski DorianMaliszewski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DorianMaliszewski @philibea @Lawndlwd